[Bug 225980] Merge Review: latex2html

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225980


Jindrich Novy <jnovy at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(jnovy at redhat.com) |




--- Comment #3 from Jindrich Novy <jnovy at redhat.com>  2009-12-11 09:47:03 EDT ---
(In reply to comment #2)
> [???] specfile is cleanly written. 
>       The spec file contains a lot of perl one-liners. 
>       Wouldn't it be better to write a patch that fixes the scripts generating
> wrong paths
>       instead of those regular expressions? 
>       Is it too difficult?

Yes, it is not trivial and it works so no need to break it.

> [FAIL] license text included in package: license not included in the package
>        It is included in the source archive.
>        It should be installed in "/usr/share/doc/latex2html-2008/"

Added.

> [NO] rpmlint is silent
> 
> $rpmlint ./latex2html-2008-3.fc13.src.rpm 
> latex2html.src:125: W: rpm-buildroot-usage %build perl -pi
> -e"s,${RPM_BUILD_ROOT},," l2hconf.pm
> latex2html.src: W: mixed-use-of-spaces-and-tabs (spaces: line 79, tab: line 92)
> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> $ rpmlint ./latex2html-2008-3.fc13.noarch.rpm 
> latex2html.noarch: E: non-executable-script
> /usr/share/latex2html/cweb2html/cweb2html 0644 /usr/bin/perl
> latex2html.noarch: W: hidden-file-or-dir
> /usr/share/latex2html/docs/.latex2html-init
> latex2html.noarch: E: non-executable-script
> /usr/share/jlatex2html/makeseg/makeseg 0644 /usr/bin/perl
> latex2html.noarch: E: non-executable-script /usr/share/latex2html/makemap 0644
> /usr/bin/perl
> latex2html.noarch: E: non-executable-script /usr/share/jlatex2html/makemap 0644
> /usr/bin/perl
> latex2html.noarch: E: wrong-script-interpreter
> /usr/share/jlatex2html/cweb2html/makemake.pl /usr/local/bin/perl
> latex2html.noarch: E: non-executable-script
> /usr/share/jlatex2html/cweb2html/makemake.pl 0644 /usr/local/bin/perl
> latex2html.noarch: E: non-executable-script
> /usr/share/jlatex2html/cweb2html/cweb2html 0644 /usr/bin/perl
> latex2html.noarch: E: non-executable-script
> /usr/share/latex2html/makeseg/makeseg 0644 /usr/bin/perl
> latex2html.noarch: W: hidden-file-or-dir
> /usr/share/jlatex2html/docs/.latex2html-init
> latex2html.noarch: E: wrong-script-interpreter
> /usr/share/latex2html/cweb2html/makemake.pl /usr/local/bin/perl
> latex2html.noarch: E: non-executable-script
> /usr/share/latex2html/cweb2html/makemake.pl 0644 /usr/local/bin/perl
> 1 packages and 0 specfiles checked; 10 errors, 2 warnings.
> 

Fixed.

> [???] %docs are not necessary for the proper functioning of the package
>       Documentation is not marked as %doc, and it is included 
>       in both /usr/share/latex2html/doc and in /usr/share/jlatex2html

"docs" and "example" directory is now marked as %doc

>       It is not compiled (just the .tex source, no .dvi/pdf/ps)
> 
>       It should be compiled, marked by %doc in %files, and it should not be 
>       included in /usr/share/latex2html.
> 
>       The file readme.hthtml should be in %doc

readme.hthtml is mistakenly twice in the tarball. The copy in the root is
bogus, thus deleted.

> 
>       /usr/share/makeseg/makeseg.tex should be built and the .dvi/pdf/ps 
>       should be included as %doc, but the .tex file should not be included.
> 

Leaving makeseg as is because it ships the makeseg script as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.