[Bug 499987] Review Request: mingw32-curl - MinGW Windows port of curl and libcurl

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 11 21:22:11 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499987





--- Comment #3 from Kalev Lember <kalev at smartlink.ee>  2009-12-11 16:22:08 EDT ---
Fedora review mingw32-curl-7.19.7-1.fc12.src.rpm 2009-12-11

+ OK
! needs attention

rpmlint says:
mingw32-curl.noarch: W: spelling-error-in-summary en_US libcurl
mingw32-curl.src: W: spelling-error-in-summary en_US libcurl
mingw32-curl-debuginfo.noarch: W: spelling-error-in-summary en_US mingw
mingw32-curl-debuginfo.noarch: W: spelling-error-in-description en_US mingw
mingw32-curl-debuginfo.noarch: E: debuginfo-without-sources
mingw32-curl-static.noarch: E:
arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libcurl.a
mingw32-curl-static.noarch: W: no-documentation
4 packages and 0 specfiles checked; 2 errors, 5 warnings.

+ rpmlint errors / warnings above are harmless and can be ignored.
+ Package is named according to the Fedora MinGW naming guidelines
+ Package follows the Fedora MinGW packaging guideliens
+ The stated license (MIT) is a Fedora approved license
+ The stated license is the same as the one for the corresponding
  native Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  26124caef7359de6338172abafa98dc0  curl-7.19.7.tar.lzma
  26124caef7359de6338172abafa98dc0  Download/curl-7.19.7.tar.lzma
+ Package builds in koji
n/a ExcludeArch bugs filed
! BuildRequires look sane, except that BR pkgconfig is probably not needed.
n/a The spec file MUST handle locales properly
+ Packages does not bundle copies of system libraries
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package contains code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
    Fedora MinGW guidelines allow headers in main package
+ Static libraries are in mingw32-curl-static
+ Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
    Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8

! This package includes curl.exe, which I believe is out of scope for Fedora
MinGW, as only development libraries are allowed. Curl.exe is a full-blown
command-line standalone cross-compiled application that is not allowed under
the Fedora MinGW rules.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list