[Bug 543480] Review Request: javamail - Java Mail API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543480


Joshua Roys <roysjosh at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roysjosh at gmail.com




--- Comment #1 from Joshua Roys <roysjosh at gmail.com>  2009-12-14 15:36:09 EDT ---
Hello,

Here's an unofficial review:

* rpmlint (the warning is in error; the _libdir macro is used inside the same
conditional that triggers the package being noarch)
$ rpmlint -vi /var/lib/mock/fedora-12-x86_64/result/javamail-*.rpm
javamail.src: I: checking
javamail.src:207: W: libdir-macro-in-noarch-package (main package)
%attr(-,root,root) %{_libdir}/gcj/%{name}
The %{_libdir} or %{_lib} macro was found in a noarch package in a section
that gets included in binary packages.  This is most likely an error because
these macros are expanded on the build host and their values vary between
architectures, probably resulting in a package that does not work properly on
all architectures at runtime. Investigate whether the package is really
architecture independent or if some other dir/macro should be instead.

javamail.x86_64: I: checking
javamail-debuginfo.x86_64: I: checking
javamail-javadoc.noarch: I: checking
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

* package is named appropriately
* spec is %{name}.spec
* spec file in general is ok; minor nitpick:
-- comment on line 112, convert license file to....?
* approved license
* license matches mail/src/main/resources/META-INF/LICENSE.txt
* license included as %doc
* specfile written in American English
* ... and is legible
* files match upstream (checked via `spectool -g' and `diff')
* builds via mock on x86_64
? ExcludeArch?  do a scratch build in koji to check compile on all archs?
* builds in mock: BuildRequires are probably correct
~ n/a locales
~ n/a ldconfig
* does not bundle copies of system libraries
~ n/a not relocatable
* handles directory ownership/creation correctly
* %files doesn't duplicate anything
* %defattr provided, proper permissions
* %clean is correct
* consistent macro usage
* package contains code
* no overly large docs
* the only %doc files are a license and a html page
~ n/a no headers
~ n/a no static libraries
~ n/a no pkgconfig files
* no foo.so.#.# files, only foo.so
~ n/a no -devel subpackage
* no .la files
* no gui app (that I'm aware of?)
* no duplicate directory ownership
* %install has a rm -rf $RPM_BUILD_ROOT
* all filenames are valid UTF-8

Hope to help.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.