[Bug 546704] Review Request: python-whoosh - Fast, pure-Python full text indexing, search, and spell checking library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546704


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review?




--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org>  2009-12-17 07:24:41 EDT ---
Review:

Good:
- name ok
- using macros
- buildroot ok
- rpmlint clean
- %clean section is there
- permissions ok
- %files section ok
- arch ok
- no .la files
- no libs
- no desktop file needed
- builds in koji


NEEDSWORK:

- description is bad: If you do a 'yum search Java' you'll get this package,
which has nothing to do with java...

in PKG-INFO is:
        Whoosh is a fast, pure-Python indexing and search library. Programmers

        can use it to easily add search functionality to their applications and

        websites. Because Whoosh is pure Python, you don't have to compile or

        install a binary support library and/or make Python work with a JVM,
yet

        Whoosh is still very fast at indexing and searching. Every part of how

        Whoosh works can be extended or replaced to meet your needs exactly.

How about that?

- BR wrong: please require only python-setuptools and not
python-setuptools-devel

- You should query upstream to include a license.txt or COPYING file. It's
referenced in PKG-INFO, but nowhere to find.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.