[Bug 546147] Merge Review: kasumi

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546147


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-12-18 05:05:18 EDT ---
Some remarks

* BR
  - Please check if gettext"-devel" is really needed for BR
  - Also "BR: automake autoconf" don't seem to be needed because
    no autotools are called during build.

* SourceURL
  - I guess the following works.
    http://dl.sourceforge.jp/kasumi/41436/kasumi-2.5.tar.gz

* %makeinstall
  - Please avoid to use %makeinstall and use "make install
DESTDIR=$RPM_BUILD_ROOT"
    instead
   
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

    ! and consider to add 'INSTALL="install -p"' to "make install" to keep
      timestamps on installed files as much as possible.

? Removing desktop
-----------------------------------------------------------
# remove .desktop file so that kasumi is accessible from 
# scim panel and it's not necessary for other users.
rm -rf $RPM_BUILD_ROOT%{_datadir}/applications/*.desktop
-----------------------------------------------------------
  - Is this also true for people using ibus (as now we use
    ibus by default) and some other input method (such as uim/uim-anthy)?
  - Does this mean that %_datadir/pixmaps/kasumi.png can also
    be removed?

* Misc rpmlint issues
-----------------------------------------------------------
kasumi.i686: W: summary-ended-with-dot C An anthy dictionary management tool.
-----------------------------------------------------------
  - Please fix above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.