[Bug 546147] Merge Review: kasumi
bugzilla at redhat.com
bugzilla at redhat.com
Mon Dec 21 07:23:02 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=546147
--- Comment #2 from Akira TAGOH <tagoh at redhat.com> 2009-12-21 02:23:01 EDT ---
Thanks for the review. I should do self-review before submitting this ;)
(In reply to comment #1)
> Some remarks
>
> * BR
> - Please check if gettext"-devel" is really needed for BR
> - Also "BR: automake autoconf" don't seem to be needed because
> no autotools are called during build.
No they aren't needed. fixed.
> * SourceURL
> - I guess the following works.
> http://dl.sourceforge.jp/kasumi/41436/kasumi-2.5.tar.gz
Aha. it didn't work before IIRC. so that might be improved at sf.jp then :)
cool. fixed.
> * %makeinstall
> - Please avoid to use %makeinstall and use "make install
> DESTDIR=$RPM_BUILD_ROOT"
> instead
fixed.
> ? Removing desktop
> -----------------------------------------------------------
> # remove .desktop file so that kasumi is accessible from
> # scim panel and it's not necessary for other users.
> rm -rf $RPM_BUILD_ROOT%{_datadir}/applications/*.desktop
> -----------------------------------------------------------
> - Is this also true for people using ibus (as now we use
> ibus by default) and some other input method (such as uim/uim-anthy)?
> - Does this mean that %_datadir/pixmaps/kasumi.png can also
> be removed?
added it back. ideally ibus-anthy should supports it as scim-anthy does and get
rid of it from the menu after that, but anyway.
> * Misc rpmlint issues
> -----------------------------------------------------------
> kasumi.i686: W: summary-ended-with-dot C An anthy dictionary management tool.
> -----------------------------------------------------------
> - Please fix above.
fixed.
please revisit the CVS again for confirming.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list