[Bug 549884] Review Request: plexus-io - Plexus IO Components

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549884


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora at gmail.com
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-12-23 08:54:25 EDT ---
I made a full review. Here are my comments, questions etc:

* Package does not build in mock. It pulls gcj. We want openjdk. I added that
BR fol the rest of the review.
As far as I know, all java packages need these BR's and R's:
   http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires

* Additionally, the guidelines tell us to include these R's for maven:
   http://fedoraproject.org/wiki/Packaging:Java#maven

* rpmlint says
   plexus-io.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-io
Is this ignorable? Why?

! javadoc package does not require the main package. (just a warning. I don't
know if this is intentional)

? Shouldn't the release tag just be 0.1.a5%{?dist}

! For macro consistency plexus-io can be replaced by %{name} at two places

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.