[Bug 523523] Review Request: clutter-gesture - Gesture Library for Clutter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523523


Christian Krause <chkr at plauener.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #4 from Christian Krause <chkr at plauener.de>  2009-12-27 08:30:30 EDT ---
Thank you very much for the update.

(In reply to comment #2)
> Fixed:
> > - Let URL tag point to specific project page on moblin.org
> > - Add MIT to license tag
> > - Remove unusual %configure flags / CFLAGS  
> 
> Reported upstream. 
> > - Package API documentation
> > - Fix public header files

I've reviewed the new package and besides the public header / pkgconfig issue
it looks fine now.

Have you already heard something from upstream?

However, since it is possible to compile eom against clutter-gesture (and the
test programs work), the header issue does not block the review.

The remaining minor non-blocking issues are:

1. Package API documentation

2. Fix public header files / pkgconfig
Please note, that /usr/lib/pkgconfig/clutter-gesture.pc also contains a
placeholder which was not replaced by the configure script:
 modlibexecdir=@modlibexecdir@
This must also be fixed.

-> APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.