[Bug 542458] Review Request: libqt4intf - Wrapper library for Qt4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542458


Alagunambi Welkin <alagunambiwelkin at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alagunambiwelkin at gmail.com




--- Comment #1 from Alagunambi Welkin <alagunambiwelkin at gmail.com>  2009-12-29 15:20:03 EDT ---
(In reply to comment #0)
Hi,

Just a quick suggestions

################################################################################
rpmlint on libqtintf4.spec throwed this,
################################################################################
libqtintf4.spec:24: W: setup-not-quiet
libqtintf4.spec: E: no-cleaning-of-buildroot %install
libqtintf4.spec: E: no-cleaning-of-buildroot %clean
libqtintf4.spec: E: no-buildroot-tag
0 packages and 1 specfiles checked; 3 errors, 1 warnings.
################################################################################rpmlint
on libqt4intf5.src.rpm
################################################################################
libqt4intf5.src: E: invalid-spec-name
libqt4intf5.src:24: W: setup-not-quiet
libqt4intf5.src: E: no-cleaning-of-buildroot %install
libqt4intf5.src: E: no-cleaning-of-buildroot %clean
libqt4intf5.src: E: no-buildroot-tag
libqt4intf5.src: W: non-standard-group System/Libraries
libqt4intf5.src: W: no-version-in-last-changelog
libqt4intf5.src: W: invalid-license LGPL v2+
libqt4intf5.src: W: no-url-tag
1 packages and 0 specfiles checked; 4 errors, 5 warnings.
################################################################################
Few suggested corrections:
################################################################################
#) Change the release form "0" to "1"
#) Change COPYING.TXT it is not mentioning which version of LGPL used
#) In SPEC Try to use "%{name}" and "%{version}" like macros, which will be
easy to update
#) In Group change "System/Libraries" to "Development/Libraries" refer to
/usr/share/doc/rpm-[version]/GROUPS
#) add "-q" along with your %setup to make it quiet: Error 1
#) echo will not be effective here
#) uncomment the "rm -rf %{buildroot}" in %clean: Error 3
#) Add "rm -rf %{buildroot}" in %{install}: Error 2
#) Error 4 can be ignored unless if you want this package to be on EPEL
#) Add your project url from where project source can be downloaded in URL tag
#) The availability of source in internet is *must*
################################################################################
For your reference
################################################################################
http://fedoraproject.org/wiki/Packaging/NamingGuidelines
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL
https://fedoraproject.org/wiki/Packaging/RPMMacros
https://fedoraproject.org/wiki/PackagingDrafts/Changelog
https://fedoraproject.org/wiki/Packaging/SourceURL
https://fedoraproject.org/wiki/PackagingGuidelines#Shared_Libraries
https://fedoraproject.org/wiki/Archive:PackagingDrafts/BuildRootHandling
################################################################################

Please do rpmlint to your spec and *.rpm files before uploading


Alagunambi Welkin

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.