[Bug 547916] Review Request: fedora-kde-icon-theme - Default icon theme for KDE Desktops on fedora

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=547916


Kevin Kofler <kevin at tigcc.ticalc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from Kevin Kofler <kevin at tigcc.ticalc.org>  2009-12-30 14:58:44 EDT ---
MUST Items:
+ rpmlint output is blank ("0 errors, 0 warnings")
+ named and versioned according to the naming guidelines
+ Name matches spec name
+ package meets Packaging Guidelines
+ License: GPLv2+ and CC-BY-SA valid, matches actual license
+ COPYING.* included as %doc
+ spec file in American English and legible
+ source matches upstream:
MD5: 81ef91585e5d0356f127559cc4477f6e
SHA1: ebe1295cd05cce7fe53a4c8a83ff1db183d3ff28
SHA256: c539f2150ee8fc0bce40291d0ab1169790128e82c5473d252e21bba08e4e1324
+ builds successfully (Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1896041 )
+ no ExcludeArch needed
+ no missing BRs
+ no translations, shared libraries, bundled system libraries
+ not relocatable
+ all created directories (not already owned by filesystem) owned
+ all files listed only once
+ permissions are sane, %defattr used properly
+ %clean section present and valid
+ macros used consistently
+ the packaged content is permissible under CodeVsContent (icon theme)
+ no large documentation files => no -doc subpackage needed
+ %doc files not required at runtime
+ no header files, static libraries, .pc files, .so files, -devel subpackage,
.la files or GUI applications
+ does not own files or directories already owned by another package
+ rm -rf %{buildroot} run at the beginning of %install
+ all filenames are valid UTF-8

SHOULD Items:
+ license texts already included in the tarball
+ no translated summary and description available, so none needs to be provided
+ builds in mock (Koji scratch build)
* arch-independent, so expected to build on all architectures, skipping all
arch test
* skipping functionality test
+ scriptlets are sane, match standard snippets
+ no subpackages => no versioned deps on the base package needed
+ no .pc files
+ no file dependencies

Nitpick: Please add README as %doc as it contains part of the licensing
information. But this is trivial and can be addressed after the import.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.