[Bug 550594] Review request: themonospot-base - core component of Themonospot suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550594





--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-12-31 02:04:54 EDT ---
For 0.8.2-1:

* BuildRequires/Requires
  - Well, I did not notice before, however:
    current rpm-build (F-11/12/13) has
/usr/lib/rpm/mono-find-{provides,requires},
    so dependency on mono .dll files should be automatically detected.
    However, for example rawhide rpmbuild-4.8.0-0.beta1.4 mono-find-requires
    reads:
-----------------------------------------------------------
    21  if [ -x $build_bindir/monodis ]; then
    22      monodis="$build_bindir/monodis"
    23      export
LD_LIBRARY_PATH=$build_libdir${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}
    24  elif [ -x /usr/bin/monodis ]; then
    25      monodis="/usr/bin/monodis"
    26  else
    27      exit 0;
    28  fi
-----------------------------------------------------------
    So to detect .dll based depedency automatically, /usr/bin/monodis is
    needed, which is in mono-devel. So:

    * Change "BR: mono-core" to "BR: mono-devel"
    * "BR: pkgconfig" is not needed because mono-devel always requires
pkgconfig
    * "Requires: mono-core" is not needed because dependency on .dll
      files will automatically be detected after using "BR: mono-devel"
      ! Note:
        For other themonospot-foo packages, writing "Requires:
themonospot-base"
        or other dll based dependencies explicitly is also no longer needed
with
        using "BR: mono-devel" (still "BR: themonospot-devel" or so is needed 
        for other themonospot-foo srpm)


* Obsoletes
(In reply to comment #8)
> > By the way what component should 
> > have "Obsoletes: themonospot" (i.e
> > remove old themonospot) ?
> yes, themonospot-base should have 
> "Obsoletes: themonospot"  
  - Then please add this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.