[Bug 476832] Review Request: mydns - serve DNS records directly from an SQL database

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 5 16:59:15 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476832





--- Comment #21 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-02-05 11:59:14 EDT ---
Created an attachment (id=331032)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=331032)
proposal for scriptlets

Well, about scriptlets:

- When mydns is first installed:
  - For main package:
    - At pre, user/group must be registered.
    * "USERNAME" used here is wrong
    - At post, chkconfig, info must be called

  - After database subpackage is first installed:
    - At post, alternatives must be called

- When mydns is upgraded:
  - For main package:
    - At post, chkconfig info must be called.

  - For database subpackage:
    - At post, alternatives must be called.
    - At postun: (here as this is "upgrading", $1 = 1)
      service mydns should be restared.

- When removal:
  - When database subpackage is to be removed:
    - When the database to be removed is actually
      selected on alternatives, service must be stopped at preun
    - On the other hand, the other database is selected,
      there is no need that service should be stopped.
    - alternatives must be called at preun to unregister
    * service itself must not be removed on subpackage removal

  - When main package itself is to be removed
    - info must be unregistered at preun
    - For safety, I think stopping service also at preun of
      main package is reasonable
    - service must be unregistered at preun

Note that I usually write "exit 0" at the end of the scriptlets
to make it sure that scriptlets surely exit with success
(even if some failure occured in the scriptlets)

I attached the proposal for scriptlets. How do you think
of this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list