[Bug 463767] Review Request: cloog - The Chunky Loop Generator

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 5 21:10:22 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463767





--- Comment #19 from Dodji Seketeli <dodji at redhat.com>  2009-02-05 16:10:21 EDT ---
> This library actually calls exit() in the library (e.g.
> source/names.c). This is unusual situation. Usually when some unexpected
> behavior happens in a function in a library, the function should
> return a value which tells the error or so and should call
> exit() ($ rpmlint -I shared-lib-calls-exit shows the explanation).

> Would you contact upstream?

Yes, sure. Though is this a blocker for the package to be sponsored ? I mean
this is typically something that can be fixed in a subsequent upstream release.
The reason why I am being a bit dense on this is that there are lots of exit()
calls in the library and changing those would require some real API design
changes. Otherwise, I would have provided a patch myself already.

I will batch forward this issue to upstream with the patch
https://bugzilla.redhat.com/attachment.cgi?id=331052 when you approve it.

Thanks for your time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list