[Bug 467421] Review Request: mingw32-gtk-vnc - MinGW Windows port of VNC client GTK widget

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467421


Richard W.M. Jones <rjones at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(rjones at redhat.com |
                   |)                           |




--- Comment #5 from Richard W.M. Jones <rjones at redhat.com>  2009-02-06 09:46:57 EDT ---
(In reply to comment #3)
> Note: SRPM URL no longer valid, and the Source0 field does not provide a URL;
> I'm reviewing the slightly modified spec, using the newest gtk-vnc release.

Right, so I've updated based on your patched spec file.

> Documentation: the guideline specifies that man and info pages can be left out
> if they duplicate the pages in the main Fedora package. But how about license
> texts, README, ChangeLog, etc. -- the files that normally go under %doc ?

What we have done in all the other MinGW packages is to
include just the license file.  The reasoning is roughly
that the other files are contained in the native Fedora
package, but the license file is in some sense "special"
because we wouldn't want to distribute some code without
the license.

> ?   library -> ldconfig (this is not needed for MinGW, I suppose?)

That's correct.  ldconfig does nothing for DLLs.

> ?   headers in -devel: presumably all mingw32- packages are meant for
>     cross-compiling, so this is irrelevant?

Yes, everything is for development in MinGW.

Here is the updated package:

Spec URL:
http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/gtk-vnc/mingw32-gtk-vnc.spec
SRPM URL: http://www.annexia.org/tmp/mingw32-gtk-vnc-0.3.8-2.fc11.src.rpm

* Fri Feb  6 2009 Richard W.M. Jones <rjones at redhat.com> - 0.3.8-2
- Needs mingw32-filesystem with the pkg-config library path fix.
- Added optional BRs suggested by auto-buildrequires.
- Include the license file.

* Tue Feb  3 2009 Michel Salim <salimma at fedoraproject.org> - 0.3.8-1
- Update to 0.3.8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.