[Bug 459444] Review Request: ctdb - Clustered TDB

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459444





--- Comment #19 from Abhijith Das <adas at redhat.com>  2009-02-06 12:43:47 EDT ---
Guenther,
Thanks for fixing the srpm. I was gonna update it myself shortly, but you beat
me to it.

I took a brief look at the spec file and I spotted a couple of things:
a. You're missing changelog info between -58 and -71. I usually pull this stuff
from the upstream srpm's spec file:
http://ctdb.samba.org/packages/redhat/RHEL5/ctdb-1.0.71-1.src.rpm. It might
also be worthwhile (if you've not already done so) to check for any changes
upstream made to their spec file since -58 that we might've missed.

b. I ran rpmlint -i on the ctdb.spec and:
[adas at radium sbose]$ rpmlint -i ctdb.spec 
ctdb.spec:82: E: use-of-RPM_SOURCE_DIR
You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
a directory for building, use $RPM_BUILD_ROOT instead.

c. I also ran rpmlint -i on the binaries:
ctdb.x86_64: W: incoherent-version-in-changelog 1.0.58-2 1.0.71-2.fc10
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.
^^ This is the changelog stuff I mentioned above

ctdb.x86_64: W: unstripped-binary-or-object /usr/sbin/ctdbd
ctdb.x86_64: W: unstripped-binary-or-object /usr/bin/smnotify
ctdb.x86_64: W: unstripped-binary-or-object /usr/bin/ctdb_ipmux
ctdb.x86_64: W: unstripped-binary-or-object /usr/bin/ctdb
ctdb.x86_64: W: service-default-enabled /etc/rc.d/init.d/ctdb
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

ctdb-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
^^ I was told that this was ok, before... maybe spot can clarify.

2 packages and 0 specfiles checked; 0 errors, 7 warnings.


The next step is that we wait for spot to review, approve and sponsor, so this
package gets into Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.