[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484535


Kevin Kofler <kevin at tigcc.ticalc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kevin at tigcc.ticalc.org




--- Comment #6 from Kevin Kofler <kevin at tigcc.ticalc.org>  2009-02-08 16:49:25 EDT ---
> kde-plasma-networkmanagement.src:25: W: unversioned-explicit-obsoletes
kde-plasma-networkmanager

That one ought to be fixed.

> kde-plasma-networkmanagement.x86_64: W: no-documentation

Mostly harmless. Is there no COPYING? That's worth a complaint upstream. TODO
and DESIGN may or may not be worth shipping.

> kde-plasma-networkmanagement.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/NetworkManager-kde4.conf

That's the usual D-Bus "config files" which aren't really "config files". It
could be marked %config, but I think it probably shouldn't, that file isn't
really intended to be customized. The path is in /etc because that's where
D-Bus expects those files to be.

> kde-plasma-networkmanagement.x86_64: W: obsolete-not-provided
kde-plasma-networkmanager

Harmless, but I think adding the Provides can't hurt and it will make "yum
install kde-plasma-networkmanager" work.

> kde-plasma-networkmanagement-debuginfo.x86_64: E: description-line-too-long
This package provides debug information for package
kde-plasma-networkmanagement.

The line exceeds 80 characters, it should be broken into 2 lines.

> kde-plasma-networkmanagement-debuginfo.x86_64: W: filename-too-long-for-joliet
kde-plasma-networkmanagement-debuginfo-0.1-0.3.20090207svn.fc10.x86_64.rpm

Ignore that one. The name is as it has to be according to the guidelines, you
can't shorten it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.