[Bug 484725] Review Request: eclipse-moreunit - Assisting in writing more unit tests plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484725





--- Comment #2 from Alexander Kurtakov <akurtako at redhat.com>  2009-02-10 11:44:35 EDT ---
New version
Spec URL:
http://akurtakov.fedorapeople.org/eclipse-moreunit.spec
SRPM URL:
http://akurtakov.fedorapeople.org/eclipse-moreunit-1.2.0-2.fc10.src.rpm


(In reply to comment #1)
> Everything looks pretty good.  The Summary and Description need a bit of
> attention.  For the summary I'd recommend something like:
> 
> "An Eclipse plugin that assists with writing more unit tests"
> 
> and for the description something like:
> 
> "MoreUnit is an Eclipse plugin that should assist with writing more unit tests.
>  It can decorate classes which have testcase(s) and mark methods in the editor
> which are under test.  Renaming/moving classes/methods will cause moreUnit to
> rename/move the corresponding test code.  Generation of test method stubs is
> also possible."
> 
> Here's the rest of the review.  Lines beginning with non-* need attention.
> 
> X make sure lines are <= 80 characters
>  - the summary line is longer but will be fixed if you change it to something
>    similar to what I suggest above
Fixed.

> 
> X changelog format okay
>   - you probably want to use your actual email address :)
Fixed.
> 
> X skim the summary and description for typos, etc.
>   - see above
Fixed. I've used your suggestions.
> 
> ? license text included in package and marked with %doc
>   - could we speak with upstream about getting them to include a copy of the
>     EPL text?  Not a blocker.
> 
License is correctly put in the license tag in the feature.xml, which is
entirely correct for eclipse plugin. I don't think it is needed to contact
upstream to make such unneeded changes. 

> X run rpmlint on the binary RPMs => no output
> 
> $ rpmlint ../RPMS/noarch/eclipse-moreunit-1.2.0-1.fc10.noarch.rpm 
> eclipse-moreunit.noarch: W: no-documentation
> 
> To fix this, you could probably mark this (or both files in this directory) as
> %doc:
> 
> eclipse-moreunit-fetched-src-V_1_2_0/org.moreunit.plugin/help/documentation.html
> 

Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.