[Bug 484933] Review Request: libwps - Library for reading and converting Microsoft Works word processor documents

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484933


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs.michael at gmx.net
         AssignedTo|nobody at fedoraproject.org    |bugs.michael at gmx.net
               Flag|                            |fedora-review?




--- Comment #1 from Michael Schwendt <bugs.michael at gmx.net>  2009-02-12 07:45:29 EDT ---
Blockers:

> mv %{buildroot}/%{_includedir}/%{name}-0.1/%{name}/* %{buildroot}/%{_includedir}/%{name}/
> rm -rf %{buildroot}/%{_includedir}/%{name}-0.1/

Not only should something like this be explained with a comment in the spec
file. Why is the default install location changed? Did you notice that this
breaks the pkgconfig files?


> make install -p DESTDIR=%{buildroot}

This is not what you want. This is make --print-data-base ...!
Most likely you wanted: make DESTDIR=%{buildroot} INSTALL="install -p"



Have you looked into adding a %check section for "make check"?


$ rpmls -p /home/qa/tmp/rpm/RPMS/libwps-doc-0.1.2-1.fc10.i386.rpm 
drwxr-xr-x  /usr/share/doc/libwps-0.1.2
-rw-r--r--  /usr/share/doc/libwps-0.1.2/CHANGES
-rw-r--r--  /usr/share/doc/libwps-0.1.2/COPYING
-rw-r--r--  /usr/share/doc/libwps-0.1.2/CREDITS
-rw-r--r--  /usr/share/doc/libwps-0.1.2/HACKING
-rw-r--r--  /usr/share/doc/libwps-0.1.2/README

These are only files, and they are also found in the main package.
I see you want to install doxygen docs, but here it didn't work out.
The %files section for the -doc subpackage is wrong, too, because

  %{_docdir}/%{name}-%{version}/

is the default location for all files in %doc lines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.