[Bug 485542] Review Request: breip-font - The Breip handwriting-style cursive font

bugzilla at redhat.com bugzilla at redhat.com
Sat Feb 14 11:38:14 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485542





--- Comment #2 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2009-02-14 06:38:13 EDT ---
1. If you have access to the fonts sources, please start by removing the
pre-built *.ttf and *.otf and only ship the result of your build in the noarch
package

2. Do not try to package both ttf and otf formats
http://fedoraproject.org/wiki/Choosing_the_right_font_format_to_package

3. The otf file in the archive looks suspiciously bigger thant the ttf file,
and it has a newer timestamp. Please check with upstream it was actually build
from the packaged sfds and not from a more recent version they forgot to
publish

4. You need to add fontforge to buildrequires if you want you package to build
in mock/koji. If you want to maintain packages in Fedora it's a good idea to
install mock on your system
http://fedoraproject.org/wiki/Projects/Mock

5. you can drop
%dir %{_fontdir}

for fedora-devel (will probably change the behaviour of the macros in F9 and
F10 too soonish)

6. your fontconfig file is not finished

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list