[Bug 485604] Review Request: gigolo - GIO/GVFS management application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485604





--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-02-15 03:47:49 EDT ---
I guess I don't have time to review this, however

* Please make the build log more verbose so we can check
  if Fedora specific compiler flags are correctly honored.
  - Usually the output like
----------------------------------------------------------------
+ ./waf build
[ 1/20] cc: src/main.c -> _build_/default/src/main_1.o
[ 2/20] cc: src/compat.c -> _build_/default/src/compat_1.o
[ 3/20] cc: src/window.c -> _build_/default/src/window_1.o
[ 4/20] cc: src/bookmark.c -> _build_/default/src/bookmark_1.o
----------------------------------------------------------------
    is not useful.
  - And actually ps auwwx shows
----------------------------------------------------------------
 8626 pts/15   S+     0:00 /bin/sh -e
/home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.KdfCEV
 8651 pts/15   Sl+    0:00 python ./waf build
 8696 pts/15   S+     0:00 /usr/bin/gcc -g -O0 -DDEBUG -Idefault -I..
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2
-I/usr/include/libpng12 ../src/common.c -c -o default/src/common_1.o
----------------------------------------------------------------
    so Fedora specific compilation flags are not correctly honored.

- Would you explain why this package does not Provide sion
  despite that this Obsoletes sion?

- --vendor="fedora" should not be used anymore.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.