[Bug 484644] Review Request: screenlets - Fully themeable mini-apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484644





--- Comment #5 from leigh scott <leigh123linux at googlemail.com>  2009-02-15 09:29:16 EDT ---
(In reply to comment #4)
> Do you mean screenlets package doesn't need to own the following directories:
> /usr/lib/python2.5/site-packages/screenlets
> /usr/share/screenlets
> /usr/share/screenlets-manager
> ? Is it ok to have unowned directories?

A package should own any directory it creates.

i.e

%files -f %{name}.lang
%defattr(-,root,root,-)
%doc AUTHORS CHANGELOG COPYING DEVELOPERS LICENCE README TODO
%{_bindir}/screenlets
%{_bindir}/screenlets-daemon
%{_bindir}/screenlets-manager
%{_bindir}/screenlets-packager
%{_bindir}/screenletsd
%dir %{python_sitelib}/screenlets
%{python_sitelib}/screenlets/*
%{python_sitelib}/screenlets-%{version}-py2.5.egg-info
%{_datadir}/applications/screenlets-manager.desktop
%{_datadir}/icons/screenlets.svg
%dir %{_datadir}/screenlets-manager
%{_datadir}/screenlets-manager/*
%dir %{_datadir}/screenlets
%{_datadir}/screenlets/*


Also I made a mistake on the desktop-file-install, it should be

desktop-file-install --vendor "" --delete-original \
  --dir $RPM_BUILD_ROOT%{_datadir}/applications \
  $RPM_BUILD_ROOT%{_datadir}/applications/%{name}-manager.desktop


I also believe the path in Icon= should be removed along with the .svg

Icon=/usr/share/icons/screenlets.svg

should be 


Icon=screenlets

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.