[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

Tue Feb 17 02:17:05 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=451744

--- Comment #14 from Joseph Smidt <jsmidt at fedoraproject.org>  2009-02-16 21:17:02 EDT ---
Request for comment:  I know this package is not ready to receive a thorough
review yet, but it has basics covered: builds, installs, etc with exit 0, no
rpmlint issues with the .spec, src and debug files.  It has been modularized,
borrowing largely from Kostas above with -devel, -libs, etc packages.

However, as I am still new at packaging, I really could use some helpful
feedback at this point.  Here are the needed files:

Spec: http://jsmidt.fedorapeople.org/root.spec
Srpm: http://jsmidt.fedorapeople.org/root-5.22.00-0.2.fc10.src.rpm

On known issue is the man package depends on the -devel package.  I don't know
any way around this since unversioned libraries and .h files are needed for
root to run properly.

I will start looking into all these issues, but thought I would make a request
for comment while I am going about it.  Thanks a lot!

Here are the outputs:

rpmlint root.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

--------------------------------------------------------------

rpmlint root-5.22.00-0.2.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

--------------------------------------------------------------

 rpmlint root-debuginfo-5.22.00-0.2.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-------------------------------------------------------------

rpmlint root-xrootd-5.22.00-0.2.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

--------------------------------------------------------------

rpmlint root-libs-5.22.00-0.2.fc10.i386.rpm 
root-libs.i386: W: no-documentation
root-libs.i386: W: non-conffile-in-etc /etc/ld.so.conf.d/root-i386.conf
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

--------------------------------------------------------------

(grepping to suppress, for now, hundreds of warnings!)

root-5.22.00-0.2.fc10.i386.rpm | grep E:root.i386: E: script-without-shebang
/usr/lib/root/ROOT.py
root.i386: E: script-without-shebang /usr/share/root/icons/bld_listtree.xpm
root.i386: E: script-without-shebang /etc/root/html/header.html
root.i386: E: script-without-shebang /usr/share/root/icons/bld_text.xpm
root.i386: E: script-without-shebang /etc/root/html/ROOT.css
root.i386: E: script-without-shebang /usr/bin/thisroot.csh
root.i386: E: non-executable-script /usr/bin/thisroot.csh 0644
root.i386: E: script-without-shebang /etc/root/html/HELP.html
root.i386: E: script-without-shebang /usr/share/root/icons/bld_canvas.1.xpm
root.i386: E: script-without-shebang /etc/root/html/ROOT.js
root.i386: E: script-without-shebang /usr/bin/thisroot.sh
root.i386: E: non-executable-script /usr/bin/thisroot.sh 0644
root.i386: E: script-without-shebang /etc/root/html/footer.html
root.i386: E: only-non-binary-in-usr-lib

--------------------------------------------------------------

root-cint-5.22.00-0.2.fc10.i386.rpm | grep E:
root-cint.i386: E: script-without-shebang
/usr/lib/root/cint/lib/win32api/make.bat
root-cint.i386: E: script-without-shebang /usr/lib/root/cint/include/makehpib
root-cint.i386: E: script-without-shebang
/usr/lib/root/cint/lib/wintcldl83/try.bat
root-cint.i386: E: script-without-shebang
/usr/lib/root/cint/lib/cintocx/setup.bat
root-cint.i386: E: non-executable-script /usr/lib/root/cint/lib/pthread/setup
0644
root-cint.i386: E: script-without-shebang
/usr/lib/root/cint/lib/wintcldl83/setup.bat
root-cint.i386: E: script-without-shebang /usr/lib/root/cint/lib/gl/setup.bat
root-cint.i386: E: script-without-shebang /usr/lib/root/cint/lib/Makefile
root-cint.i386: E: script-without-shebang
/usr/lib/root/cint/lib/longlong/make.bat
root-cint.i386: E: zero-length /usr/lib/root/cint/lib/cintocx/Cint-Ocx
root-cint.i386: E: script-without-shebang
/usr/lib/root/cint/lib/wintcldl83/wildc.bat
root-cint.i386: E: script-without-shebang /usr/lib/root/cint/lib/qt/setup.bat
root-cint.i386: E: non-executable-script /usr/lib/root/cint/lib/WildCard/setup
0644
root-cint.i386: E: non-executable-script /usr/lib/root/cint/lib/dll_stl/setup
0644
root-cint.i386: E: script-without-shebang /usr/lib/root/cint/stl/_climits
root-cint.i386: E: non-executable-script
/usr/lib/root/cint/lib/WildCard/ARCHIVE 0644
root-cint.i386: E: script-without-shebang
/usr/lib/root/cint/include/matrixstream.hi
root-cint.i386: E: devel-dependency root-devel

--------------------------------------------------------------------

rpmlint root-docs-5.22.00-0.2.fc10.i386.rpm | grep E:
root-docs.i386: E: wrong-script-end-of-line-encoding
/usr/share/doc/root-5.22.00/tutorials/gui/mditestbg.xpm
root-docs.i386: E: wrong-script-end-of-line-encoding
/usr/share/doc/root-5.22.00/tutorials/image/mditestbg.xpm

---------------------------------------------------------------------

rpmlint root-proofd-5.22.00-0.2.fc10.i386.rpm 
root-proofd.i386: W: non-conffile-in-etc /etc/root/proof/motd.sample
root-proofd.i386: W: non-conffile-in-etc /etc/root/proof/xpd.groups.sample
root-proofd.i386: W: non-conffile-in-etc /etc/root/proof/proof.conf.sample
root-proofd.i386: W: non-conffile-in-etc /etc/root/proof/cluster.conf.sample
root-proofd.i386: W: non-conffile-in-etc /etc/root/daemons/proofd.xinetd
root-proofd.i386: W: non-conffile-in-etc /etc/root/proof/noproof.sample
root-proofd.i386: W: non-conffile-in-etc /etc/root/proof/xpd.cf.sample
root-proofd.i386: W: non-conffile-in-etc /etc/root/proof/rootnetrc.sample
1 packages and 0 specfiles checked; 0 errors, 8 warnings.

----------------------------------------------------------------------

rpmlint root-rootd-5.22.00-0.2.fc10.i386.rpm 
root-rootd.i386: W: non-conffile-in-etc /etc/root/daemons/rootd.xinetd
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.