[Bug 485993] Review Request: perl-CPANPLUS-Shell-Default-Plugins-Diff - Diff module versions from the CPANPLUS shell
bugzilla at redhat.com
bugzilla at redhat.com
Wed Feb 18 08:15:43 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485993
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-02-18 03:15:41 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1133957
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0d8ad0864a840a7ae2654953c2d0f380
CPANPLUS-Shell-Default-Plugins-Diff-0.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=5, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.06 cusr 0.00
csys = 0.06 CPU)
+ Package perl-CPANPLUS-Shell-Default-Plugins-Diff-0.01-2.fc11 =>
Provides:
perl(CPANPLUS::Shell::Default::Plugins::Diff) = 0.01
Requires:
perl(CPANPLUS::Error)
perl(Data::Dumper)
perl(File::Basename)
perl(Locale::Maketext::Simple)
perl(Params::Check)
perl(Text::Diff)
perl(strict)
perl(vars)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list