[Bug 477570] Review Request: couchdb - A document database server, accessible via a RESTful JSON API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477570





--- Comment #7 from Peter Lemenkov <lemenkov at gmail.com>  2009-02-18 03:21:30 EDT ---
(In reply to comment #5)

> > * I also think that the mochiweb should be excluded and packaged separately.
> > How different version, shipped with couchdb, from the upstream one?
> I think is better wait for first official release of mochiweb.

OK, let's wait. But keep im mind that you must remove mochiweb from couchdb as
soon as mochiweb will be packaged (someday, I hope) for Fedora.

> > * "Requires: %{_bindir}/icu-config" looks ugly. First, is it really need, to
> > have libicu-devel, to couchdb to work? Second, why you decided to require
> > %{_bindir}/icu-config instead of libicu-devel?
> Using "requires: libicu-devel results in two erros in rpmlint output:

Yes, but I still think that it's more understandable for others. In any case,I
personally still don't understand why couchdb needs devel-package to work.

> > * No need to explicitly require shadow-utils (as Hubert already mentioned).
> > * remove 'exit 0' in %pre
> I following http://fedoraproject.org/wiki/Packaging/UsersAndGroups

OK.

> > * use %{_initrddir} instead of %{_sysconfdir}
> I don't see is wrong here, i using %{_initrddir}/couchdb for sysvinit script.

Looks like this is my fault - I definitely confused with something. In any case
- the current spec-file looks ok in terms of using  %{_initrddir} and
%{_sysconfdir}.


However some things still remains unresolved.

* sed oneliner at line 67 should be changed - you must use %{_localstatedir}
instead of /var
* Consider using /etc/sysconfig ( %{_sysconfdir}/sysconfig ) instead of
/etc/default for storing init-script's settings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.