[Bug 483838] Review Request: vmware-view-open-client - Client for Windows desktops managed by VMware View

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483838





--- Comment #7 from Lubomir Rintel <lkundrak at v3.sk>  2009-02-19 04:40:26 EDT ---
(In reply to comment #4)
...
> Bad:
> - Package should have 'ExclusiveArch: %{ix86}'

Golly! It contains i386 assembly code. Oh, how Enterprisey! :)
I'll fix that, in next spin of the package (probably after I fix the openssl
issue and we agree on the split of documentation)

> - Package should use desktop-file-install as described in the
> packaging guildlines
> - Start of the application caused the following error messages:
> SSLLoadSharedLibrary: Failed to load library
> libcrypto.so.0.9.8:/usr/lib/libcrypto.so.0.9.8: Kann die Shared-Object-Datei
> nicht öffnen: Datei oder Verzeichnis nicht gefunden
> SSLLoadSharedLibrary: Failed to load library
> libcrypto.so.0.9.8:/usr/lib/libcrypto.so.0.9.8: Kann die Shared-Object-Datei
> nicht öffnen: Datei oder Verzeichnis nicht gefunden

Hm, hm, hm, for me it worked. Did you build it and run it on different
versions? (e.g. F9 vs. Rawhide?). If not, please tell me which release did you
compile & run on and.

It would be awesome if you could tell me which versions of openssl and
openssl-devel did you use, as well as attaching the build log.

> - Copyright note in the sources says, that LGPLv2+ is the valid license
> specification
> for the license tag

 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation version 2.1 and no later version.

This is from brokerDlg.cc. It specifically says "no later version".

> - %doc stanza is large. So it may be nice, if you can put
> View_Client_Admin_Guide.pdf
> and View_Client_Help.pdf in a separate subpackage

I would agree, given the package is intended for thin clients, which are
usually space-constrained, but looking at the size of binary itself compared to
the documentation, I'm quite hesitant to split that:

$ du -sh vmware-view doc/*pdf
5.5M    vmware-view
528K    doc/View_Client_Admin_Guide.pdf
548K    doc/View_Client_Help.pdf

What do you think? If you still think the split is a good idea, I'll do that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.