[Bug 225847] Merge Review: gnupg

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225847


Nalin Dahyabhai <nalin at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(nalin at redhat.com) |




--- Comment #3 from Nalin Dahyabhai <nalin at redhat.com>  2009-02-19 15:32:26 EDT ---
(In reply to comment #1)
> Hi Nalin.  Here's a review for gnupg.

Thanks for that, sorry for the delay.

> NEEDSWORK items
> 
> * rpmlint produces several warnings and errors on the srpm

Fixed up at various times by various people... looks pretty clean now.

> The binary rpm produces one warning:
> 
> $ rpmlint gnupg-1.4.6-4.fc6-results/gnupg-1.4.6-4.fc6.i386.rpm 
> W: gnupg file-not-utf8 /usr/share/man/man1/gpg.ru.1.gz
> 
> I don't know Russian so I couldn't verify if iconv would properly converted the
> man page so I left it alone.

rpmlint says this needs to be UTF-8, but it's evidently KOI8-RU.  Converting.

> * Scriplets are sane
> 
> The scriptlets to install info pages could be simplified somewhat and made more
> consistent with the examples in Packaging/ScriptletSnippets

The additional checks fix #91641 (error when installed with --excludedocs). 
I'd rather just leave it as-is and not have to worry about that.

> Comments/Questions/Notes
> 
> There are a number of unneeded configure flags to enable zlib, bzip, readline,
> and curl.  These are all enabled by default in the current gnupg so they can be
> removed.

Dropped explicit requests for bzip, readline, and curl, but leaving the one for
zlib in so that configure won't fall back to the internal copy if something
looks "off" about the system one.

> Why is %{_libdir} used for %{_libexecdir}?  Packaging/Guidelines allow the use
> of this dir and it is what upstream does by default.  %{_libdir}/gnupg is used
> for extensions, though none are currently shipped with this package (or by any
> others in Fedora AFAIK).

We used to not allow %{_libexecdir}.  Reverted.

> Another very a minor point, the preferred value for the BuildRoot tag is
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> This is not a blocker.

Changed to match at some point.  I think it looks pretty good now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.