[Bug 476404] Review Request: bullet - 3D Collision Detection and Rigid Body Dynamics Library

bugzilla at redhat.com bugzilla at redhat.com
Fri Feb 20 11:04:33 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476404





--- Comment #23 from Bruno Mahe <bruno at gnoll.org>  2009-02-20 06:04:31 EDT ---
Thank you very much for this thorough review.

I believe I have fixed most of the issues you pointed out.
But I don't understand one of them.

>From your previous message :
"* ldconfig symlinks
------------------------------------------------------------------------
]# ls -al /usr/lib/libBulletCollision*
lrwxrwxrwx 1 root root     26 2009-02-18 00:56 /usr/lib/libBulletCollision.so
-> libBulletCollision.so.2.73
-rwxr-xr-x 1 root root 706252 2009-02-17 00:34
/usr/lib/libBulletCollision.so.2.73
------------------------------------------------------------------------
  - Usually in this case the (soft) symlink named "libBulletCollision.so.2"
    which points to libBulletCollision.so.2.73 should also be provided
    and the symlink (libBulletCollision.so.2) should be included in
    bullet package
    (see libjpeg and libjpeg-devel rpms for example)"

CMake doesn't generate any libBullet*.so.2.
Here is the content of my buildroot if I don't clean it up :
lrwxrwxrwx 1 makerpm makerpm     26 2009-02-20 01:56 libBulletCollision.so ->
libBulletCollision.so.2.73
-rwxr-xr-x 1 makerpm makerpm 684996 2009-02-20 01:56 libBulletCollision.so.2.73
lrwxrwxrwx 1 makerpm makerpm     25 2009-02-20 01:56 libBulletDynamics.so ->
libBulletDynamics.so.2.73
-rwxr-xr-x 1 makerpm makerpm 235368 2009-02-20 01:56 libBulletDynamics.so.2.73
lrwxrwxrwx 1 makerpm makerpm     25 2009-02-20 01:56 libBulletSoftBody.so ->
libBulletSoftBody.so.2.73
-rwxr-xr-x 1 makerpm makerpm 225420 2009-02-20 01:56 libBulletSoftBody.so.2.73
lrwxrwxrwx 1 makerpm makerpm     21 2009-02-20 01:56 libLinearMath.so ->
libLinearMath.so.2.73
-rwxr-xr-x 1 makerpm makerpm  41196 2009-02-20 01:56 libLinearMath.so.2.73

And my spec file I include %{_libdir}/*.so.* files for the bullet package and
%{_libdir}/*.so for bullet-devel.
libjpeg spec file is doing similar things.

Does that mean I should dig around CMake and make sure files like
libBullet*.so.2 are also generated ?



I updated the spec file and the SRPM.
Spec file : http://www.gnoll.org/download/bullet.spec
SRPM : http://www.gnoll.org/download/bullet-2.73-4.fc10.src.rpm


Thanks again!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list