[Bug 486248] Review Request: terminus-fonts - Clean fixed width font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486248


Nicolas Mailhot <nicolas.mailhot at laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|nicolas.mailhot at laposte.net |
         AssignedTo|nobody at fedoraproject.org    |nicolas.mailhot at laposte.net
               Flag|                            |fedora-review?,
                   |                            |needinfo?(rhbugs at n-dimensio
                   |                            |nal.de)




--- Comment #6 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2009-02-20 06:58:11 EDT ---
1. You can safely drop this comment
# Do not trust font metadata versionning unless you've checked upstream does
# update versions on file changes. When in doubt use the timestamp of the most
# recent file as version.

2. Are you sure you want to keep this Provide?
Provides: terminus-font-x11 = 4.28-2
http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#Do_I_need_to_Provide_my_old_package_names.3F

3. You can probably use the common_desc trick found in
/etc/rpmdevtools/spectemplate-fonts-multi.spec

to simplify your spec

4. Group:  User Interface/X is a bit ironic for the console package

5. If you only push your package to rawhide (as you should do), I think you can
assume filesystem is at the right version
Requires: filesystem >= 2.4.11-1
http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#Do_I_need_to_change_my_package_in_stable_releases_in_addition_to_Rawhide.2Fdevel.3F

6. FPC will ask you to use globals instead of defines soonish
http://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define

7. Do you really need to hardcode /etc in the catalog path?

8. It's a bit saner to put Provides/Obsoletes next to other rpm dependency
rules (requires/buildrequires)

9. you do not need %dir %{_fontdir} anymore
https://admin.fedoraproject.org/updates/fontpackages-1.20-1.fc10

10. really adding a fontconfig file which is effectively a noop helps no one.
Please take a look at the templates in /usr/share/fontconfig/templates/ they're
not hard a all to fill

11. the symlinks warning of rpmlint is totally bogus and FRPC already decided
to have it nuked
http://fedoraproject.org/wiki/PackagingDrafts/Symlinks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.