[Bug 457160] Review Request: Zorba - General purpose XQuery processor implemented in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457160





--- Comment #17 from Michael Schwendt <bugs.michael at gmx.net>  2009-02-23 04:24:54 EDT ---
The LaTeX/TeX/dvips BuildRequires in comment 13 are because of this build
failure in koji:

-- latex command LATEX_COMPILER not found but usually required. You will
probably get warnings and user inetraction on doxy run.
-- makeindex command MAKEINDEX_COMPILER not found but usually required.
-- dvips command DVIPS_CONVERTER not found but usually required.
[...]
-- Configuring incomplete, errors occurred!

/usr/bin/makeindex is provided by package "texlive", so if LaTeX is truely
optional, you would need the "tex(tex)" BuildRequires I marked redundant.

[...]

* src.rpm size has increased by factor 3. The spec %changelog doesn't mention
that you've replaced the source tarball with one that differs from the previous
package by a 25M diff. In case it is a snapshot retrieved from a SCM system,
you need to follow:

  https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
  https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages

* rpmdev-diff also reveals an added space character in the %cmake invocation
that is not commented on. Two of the three -D options now put a space between
-D and the variable name. No reason to believe it doesn't work, it's just
strange. With other commands, silently added whitespace may lead to problems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.