[Bug 453847] Review Request: grid-packaging-tools - The Grid Packaging Tools (GPT)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453847


Hans de Goede <hdegoede at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |hdegoede at redhat.com




--- Comment #20 from Hans de Goede <hdegoede at redhat.com>  2009-02-23 08:34:16 EDT ---
(In reply to comment #19)
> (In reply to comment #18)
> > 

<snip>

> > * These 2 rpmlint messages:
> > grid-packaging-tools.noarch: E: non-executable-script
> > /usr/share/globus/aclocal/bootstrap.frg 0644
> > grid-packaging-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 115,
> > tab: line 1)
> 
> The /usr/share/globus/aclocal/bootstrap.frg file is a script fragment - it is
> not intended to be executable standalone. It does have a shebang so that when
> put together with other pieces to create a complete script that script will be
> executable. Making the fragment executable would silence rpmlint, but it would
> contradict the intended usage of the file.
> 

Ok, I'm fine with ignoring the rpmlint output then

> The specfile uses tabs everywhere for indentation. However it is not possible
> to enter 1.375 tabs. For this you have do 1 tab + 3 spaces. Line 115 (now 120)
> starts with a tab, so I don't see why rpmlint complains about it using spaces
> for indentation. If there at some place in the file was a tab immediately
> following a space, or a set of 2 or more consecutive spaces crossing or ending
> at an even 8 column boundary then the warning would make sense. This is not the
> case. I consider this warning a "false positive" - at least for my
> understanding of what mixed-use-of-spaces-and-tabs means.
> 

I agree, one could even call it a bug, so ignore this one too.

> New version available here:
> 
> http://www.grid.tsl.uu.se/repos/globus/info/grid-packaging-tools.spec
> http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/grid-packaging-tools-3.2-14.fc10.src.rpm

Looks good! Once 2 more packages are in good shape I'll sponsor you and approve
all 3. I'm not doing the approving right now, as some people run scripts in the
flags that sets, checking all approved packages have been imported in to CVS,
etc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.