[Bug 484202] Review Request: perl-Test-JSON - Test JSON data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484202


Miroslav Suchy <msuchy at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Miroslav Suchy <msuchy at redhat.com>  2009-02-24 07:32:46 EDT ---
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1156435
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
9d8f4c2e724f67e66317f06efaa53e03 for both Test-JSON-0.06.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
not tested - package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
N/A no headers or static libraries.
N/A no .pc file present.
N/A no -devel subpackage
N/A no .la files.
N/A no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
t/00-load.........# Testing Test::JSON 0.06, Perl 5.010000, /usr/bin/perl
ok
t/10testjson......ok
t/pod-coverage....ok
t/pod.............ok
All tests successful.
Files=4, Tests=39,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.21 cusr  0.05
csys =  0.29 CPU)
Result: PASS
+ Package perl-Test-JSON:
Provides: perl(Test::JSON) = 0.06
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies)
<= 3.0.3-1
Requires: perl(Carp) perl(JSON::Any) perl(Test::Builder)
perl(Test::Differences) perl(strict)


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.