[Bug 484560] Review Request: pydb - An expanded version of the Python debugger

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 25 09:18:15 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484560





--- Comment #2 from Michael Schwendt <bugs.michael at gmx.net>  2009-02-25 04:18:13 EDT ---
* Preferably bump "Release" prior to offering new src.rpm builds. That's
helpful when using rpmdev-diff. Here the 1.25-3.fc10 has been modified
silently.


* "Group" could be "Development/Debuggers"


* "License: GPLv2+" and the source files mention GPL 2 or later, but file
"COPYING" is the GPL 3. Can you get upstream to clarify this?


* Instead of

  %{_mandir}/man1/%{name}.1.gz

prefer

  %{_mandir}/man1/%{name}.1*

since the manual pages get compressed automatically, and the compression method
and file extension may change.


* Why "BuildRequires: fontconfig"?


* It's good packaging-practice to run a test-suite target, if available, and
provided that it is not known to be broken:

--- pydb.spec.orig      2009-02-25 00:37:38.000000000 +0100
+++ pydb.spec   2009-02-25 09:46:13.000000000 +0100
@@ -44,6 +44,9 @@
 make install DESTDIR=%{buildroot}
 ln -sf ../..%{python_sitelib}/%{name}/%{name}.py
%{buildroot}%{_bindir}/%{name}

+%check
+make check
+
 %clean
 rm -rf %{buildroot}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list