[Bug 480102] Review Request: weka - Waikato Environment for Knowledge Analysis

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480102





--- Comment #2 from Michel Alexandre Salim <michel.sylvan at gmail.com>  2009-02-25 15:31:08 EDT ---
General guidelines:

MUST

+ rpmlint
+ package name
+ spec file name
+ package guideline-compliant
+ license complies with guidelines
+ license field accurate
+ license file not deleted
+ spec in US English
+ spec legible
+ source matches upstream
+ builds under >= 1 archs, others excluded
  noarch
+ build dependencies complete
N/A locales handled using %find_lang, no %{_datadir}/locale
+ own all directories
+ no dupes in %files
+ permission
+ %clean RPM_BUILD_ROOT
+ macros used consistently
+ Package contains code
+ large docs => -doc (-javadoc)
+ doc not runtime dependent

- desktop file uses desktop-file-install

  Desktop file uses desktop-file-install, but the path to the icon is wrong:
  /usr/share/icons/weka.ico rather than just
  1. weka (which is preferable) or 
  2. the correct path (/usr/share/icons/hicolor/yadda yadda)

  It looks like .ico files are not automatically picked up by GNOME's menu,
  so I'd consider converting the icon to .png (it makes it smaller as well),
  in which case you can just refer to it as Icon=weka. Otherwise, you'd have
  to use the complete path

  Also, icon caches are not updated:
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache


+ clean buildroot before install
• filenames UTF-8

SHOULD
+ package build in mock on all architectures
+ package functioned as described
+ scriplets are sane
+ other subpackages should require versioned base
+ require package not files

Java-specific:
http://fedoraproject.org/wiki/Packaging/Java

- Java requirement must be versioned (see BuildRequires and Requires)

Otherwise, it looks fine, so I can approve this after the fixes are made.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.