[Bug 486044] Review Request: php-pear-Config -Configuration file manipulation for PHP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486044





--- Comment #2 from Bernard Johnson <bjohnson at symetrix.com>  2009-02-25 19:23:38 EDT ---
(In reply to comment #1)
> First Notes :
> 
> - As optional deps are available it should be usefull to add it
> Requires: php-pear(XML_Parser) php-pear(XML_Util)

added

> - I prefer the use of %{name}.xml rather than %{pear_name}.xml (see recent
> change to PHP Guidelines, this will avoid conflict with package from other
> channel)

I did not find anything in the PHP guidelines, but I think I understand your
intention.  Please check and see if my updates to the package achieve this.

> - A comment about running test-suite will be usefull
> 14 PASSED TESTS
> 0 SKIPPED TESTS
> 2 FAILED TESTS:
> Have you encounter and investigate this issue ? (at least, reported upstream)

Two of the tests are badly written and fail.  There is no problem with the
functionality of the package.

> 
> - %file must be fixed, should be
> %{pear_phpdir}/Config*

fixed

Spec URL: http://fedorapeople.org/~bjohnson/php-pear-Config.spec
SRPM URL:
http://fedorapeople.org/~bjohnson/php-pear-Config-1.10.11-2.fc10.src.rpm

* Wed Feb 25 2009 Bernard Johnson <bjohnson at symetrix.com> - 1.10.11-2
- add dependencies for php-pear(XML_Parser) and php-pear(XML_Util)
- change from %%{pear_name}.xml to %%{name}.xml to avoid channel conflicts
- changes %%files section from %%{pear_phpdir}/* to %%{pear_phpdir}/Config*
- note regarding test suite failures added

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.