[Bug 455226] Review Request: php-pecl-runkit - PHP Opcode Analyser

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 26 07:28:34 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455226





--- Comment #12 from Pavel Alexeev <pahan at hubbitus.spb.su>  2009-02-26 02:28:33 EDT ---
(In reply to comment #11)
> Why do you use 
>     install modules/%{peclName}.so %{buildroot}%{php_extdir}
> 
> Rather than (which also create the destination dir)
>     make install INSTALL_ROOT=$RPM_BUILD_ROOT
I do not remember now. It have any sense?

> Doesn't build for me :
> - %doc %{peclName}-%{version}/README
> + %doc %{peclName}/README
Thank you. Fixed.

> rpmlint : 
> php-pecl-runkit.src: I: checking
> php-pecl-runkit.src:39: W: unversioned-explicit-obsoletes php-pear-%{peclName}
> php-pecl-runkit.src: W: summary-not-capitalized runkit - mangle with user
> defined functions and classes
Name deleteed from all summary and capitalized.

> php-pecl-runkit.src: W: non-standard-group Development/Languages/PHP
Changed to Development/Libraries
> php-pecl-runkit.x86_64: I: checking
> php-pecl-runkit.x86_64: W: summary-not-capitalized runkit - mangle with user
> defined functions and classes
Fixed, see before.

> - stuff php-pear-%{peclName} is not usefull in Fedora (php-pear-runkit don't
> exists AFAIK)
Excuse me, I think do not understand you. You speak about unnecessary
Obsoletes: php-pear-%{peclName}? I think you are rigth, it may be safely
removed in this case. I do it.

rpmlint silent now. I am sorry that is not checked immediately.

http://hubbitus.net.ru/rpm/Fedora9/php-pecl-runkit/php-pecl-runkit-0.9-8.CVS20090215.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list