[Bug 478614] Review Request: python-transitfeed - Google Transit Feed Specification library and tools

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 2 07:26:01 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478614





--- Comment #2 from Jon Stanley <jonstanley at gmail.com>  2009-01-02 02:26:00 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
See Notes - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
$ md5sum transitfeed-1.1.9.tar.gz
/data/home/jstanley/Download/transitfeed-1.1.9.tar.gz 
709ab37eaaa3b56e7ff5f874091aa390  transitfeed-1.1.9.tar.gz
709ab37eaaa3b56e7ff5f874091aa390 
/data/home/jstanley/Download/transitfeed-1.1.9.tar.gz

N/A - Package needs ExcludeArch
OK - BuildRequires correct
N/A - Spec handles locales/find_lang
N/A - Package is relocatable and has a reason to be.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK - Package is code or permissible content.
N/A - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.

N/A - Headers/static libs in -devel subpackage.
N/A - Spec has needed ldconfig in post and postun
N/A - .pc files in -devel subpackage/requires pkgconfig
N/A - .so files in -devel subpackage.
N/A - -devel package Requires: %{name} = %{version}-%{release}
N/A - .la files are removed.

N/A - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

   python-transitfeed-1.1.9-2.fc10.noarch.rpm
   python-transitfeed = 1.1.9-2.fc10
-----------------------------------
   /usr/bin/python  
   python(abi) = 2.5
   pytz  

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
Didn't test - Should function as described.
OK - Should have sane scriptlets.
N/A - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
OK - Should package latest version
N/A - check for outstanding bugs on package. (For core merge reviews)

Issues:

1. As noted previously, /usr/bin/merge is a file conflict with RCS. That's a
blocker :(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list