[Bug 478674] Review Request: pp3 - Creation of sky charts in Postscript or PDF format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478674





--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk>  2009-01-05 06:50:40 EDT ---
1.) You do not need to unpack the first (zero-th) tarball two times. And do not
need to move the manual directory.

%setup -q
%setup -q -b1
cp -vr ../manual/ . 

This seems useless to me. Skip the first line. (In case you're keeping the
manual tarball). And unpack the manual directory in place:

%setup -q -a1

2.) Please do not use the dependency on obsolete package (tetex):

Requires:       tetex-latex

this would be more appropriate:

Requires:       tex(latex)

(In reply to comment #2)
> 4) Make info is trying to generate pdf files out of examples using pp3 itself -
> I thought adding BUILD_ROOT to PATH isn't the best idea as we don't need these
> files anyway if we are shipping it with pp3-1.3.3-manual.tar.gz - What do you
> think about it? 

I think you should be generating the manual, and adding build root to path is
perfectly legal way to do that. Alternatively, you could patch the makefile to
use ../pp3 instead of pp3 when building documentation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.