[Bug 459946] Review Request: pfscalibration - Scripts and programs for photometric calibration

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 7 09:00:41 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459946





--- Comment #12 from Ulrich Drepper <drepper at redhat.com>  2009-01-07 04:00:40 EDT ---
(In reply to comment #11)
> The compiler should be called with the full set of %{optflags} or the resulted
> debuginfo package will be broken.

The flags provided are used.  There are just some additional flags passed. 
Nothing got broken.

Anyway, I have changed it slightly, similar to the way it is done in the pfstmo
package.  I'm now replacing the -O2 option only with some additional options
for higher optimization.  These higher optimizations are appropriate in this
case.

> Please also include COPYING file in the %doc section of the package.
> It would be also nice to add README files, ChangeLog and AUTHORS.

I did that.

The resulting files are here:

Spec URL: http://people.redhat.com/drepper/pfscalibration.spec
SRPM URL: http://people.redhat.com/drepper/pfscalibration-1.4-3.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list