[Bug 468376] Review Request: mingw32-SDL - MinGW Windows port of SDL cross-platform multimedia library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468376


Adel Gadllah <adel.gadllah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |adel.gadllah at gmail.com
               Flag|                            |fedora-review?




--- Comment #2 from Adel Gadllah <adel.gadllah at gmail.com>  2009-01-07 07:26:50 EDT ---
REVIEW:

[+] = OK
[-] = NOT OK
[1] = SEE COMMENTS
[?] = WTF?

=============================

[+] source files match upstream:
 sha1:  http://www.libsdl.org/release/SDL-1.2.13.tar.gz
[+] package meets naming and versioning guidelines.
[+] specfile is properly named, is cleanly written and uses macros
consistently.
[+] dist tag is present.
[+] build root is correct.
[+] license field matches the actual license.
[+] license is open source-compatible.
  LGPLv2+
[-] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] compiler flags are appropriate.
[+] %clean is present.
[+] package builds in koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1037809
[+] package installs properly.
[1] rpmlint is silent.
[+] no shared libraries are added to the regular linker search paths.
[+] owns the directories it creates.
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[2] file permissions are appropriate.
[+] no scriptlets present.
[+] code, not content.
[+] documentation is small, so no -docs subpackage is necessary.
[+] %docs are not necessary for the proper functioning of the package.
[3] no headers.
[+] no pkgconfig files.


================================

COMMENTS:

Please package the COPYING file.

[1]: no there are warings like this:

"mingw32-SDL.noarch: W: manpage-not-gzipped
/usr/i686-pc-mingw32/sys-root/mingw/share/man/man3/SDL_SetColorKey.3"

Those can be fixed with a line like this:

find $RPM_BUILD_ROOT%{_mingw32_mandir}/man3/ -type f -not -name '*.gz' -print |
xargs gzip -9f

"mingw32-SDL.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libSDLmain.a"

Package used for cross-compiling so this is a non issue.

"mingw32-SDL.noarch: W: non-standard-dir-in-usr i686-pc-mingw32"

Used in all mingw32 packges.

"mingw32-SDL.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libSDL.dll.a"

Why is this executeable ?

"mingw32-SDL.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/SDL/SDL_events.h"

Fine, because package is only used for cross compiling.

[2]:
See comment in [1] regarding
/usr/i686-pc-mingw32/sys-root/mingw/lib/libSDL.dll.a

[3]: 
Is OK, see comment in [1]

===================================

Package looks good, please fix the issues noted above and I will approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.