[Bug 459946] Review Request: pfscalibration - Scripts and programs for photometric calibration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459946


Lucian Langa <cooly at gnome.eu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #18 from Lucian Langa <cooly at gnome.eu.org>  2009-01-08 08:00:42 EDT ---
Review:

OK  source files match upstream:
        1844a6e3f03f585dbc8bcc3eaacf66b9  pfscalibration-1.4.tar.gz
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  summary is OK.
OK  description is OK.
OK  dist tag is present.
OK  build root is OK.
OK  license field matches the actual license.
OK  license is open source-compatible.
OK  license text included in package.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
        -O3 preference was explained in specfile
        -g is now present, debuginfo package complete.
OK  %clean is present.
OK  package builds in mock (rawhide, x86_64).
OK  package installs properly.
OK  debuginfo package looks complete.
OK  rpmlint is silent.
OK  final provides and requires are sane:
        pfscalibration = 1.4-4.fc10
        pfscalibration(x86-64) = 1.4-4.fc10
        =
        /bin/bash
        /usr/bin/perl
        dcraw
        jhead
        libc.so.6()(64bit)
        libgcc_s.so.1()(64bit)
        libgomp.so.1()(64bit)
        libm.so.6()(64bit)
        libpfs-1.2.so.0()(64bit)
        libpthread.so.0()(64bit)
        libstdc++.so.6()(64bit)
        perl
        perl(Getopt::Long)
        rpmlib(CompressedFileNames) <= 3.0.4-1
        rpmlib(PayloadFilesHavePrefix) <= 4.0-1
        rtld(GNU_HASH)
N/A no shared libraries are added to the regular linker search paths.
N/A owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  code, not content.
OK  documentation is small, so no -doc subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no static libraries.
OK  no libtool .la files.

remove duplicated %doc at the end of %files section.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.