[Bug 459535] Review Request: backup-manager - A command line backup tool for GNU/Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459535





--- Comment #14 from Christoph Wickert <fedora at christoph-wickert.de>  2009-01-10 11:52:56 EDT ---
(In reply to comment #13)
> > I would like to at least see a list of the tests you have done on this package.
> 
> As any reviewer should, I have checked these items :
> http://fedoraproject.org/wiki/Packaging/ReviewGuidelines#Things_To_Check_On_Review

No you didn't. The review guidelines state: "MUST: rpmlint must be run on every
package. The output should be posted in the review." The output includes some
warnings of which at least one needs to be fixed, but you did not post the
output here.

The review guidelines also state: "MUST: The package must meet the Packaging
Guidelines." and the packaging guidelines include: "When downloading sources,
patches etc, consider using a client that preserves the upstream timestamps."
You did not check the timestamps, did you?


@Guillaume: I'd like to have a look on these packages once more, so please wait
a little. TIA!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.