[Bug 428567] Review Request: ETL - Extended Template Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=428567


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lkundrak at v3.sk




--- Comment #62 from Lubomir Rintel <lkundrak at v3.sk>  2009-01-10 12:24:39 EDT ---
New upstream release (stepping in since the original submitter seems
unresponsive):

SRPMS: http://v3.sk/~lkundrak/SRPMS/ETL-0.04.12-4.el5.src.rpm
SPEC: http://v3.sk/~lkundrak/SPECS/ETL.spec

* HAVE_* macros have been renamed to avoid clash with autoconf. "config.h-like"
file etl_profile.h was not removed, since upstream does not do that, and I tend
to think that it's the good way to go.

See -- this would add a requirement for programs that use this to define ~10
macros prior to include the header, which can be non-trivial and ugly for
programs that don't rely on autoconf && friends. And in case a new one gets
added it could unnecessarily break compatibility, possibly resulting into
builds with feature set smaller than intended. I don't think doing that with
this added maintenance cost is a good idea. There is a prior art as well --
many packages hardcode feature set at build time.

Rpmlint is silent, this builds in f11 mock and synfig with synfig studio build
cleanly against this as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.