[Bug 479647] Review Request: perl-Devel-Dumpvar - Pure-OO reimplementation of dumpvar.pl
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jan 13 07:34:39 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479647
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-01-13 02:34:38 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1048777
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
751632a35f17c95c8d31ba2fe5aab44b Devel-Dumpvar-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=12, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.07 cusr 0.01
csys = 0.10 CPU)
+ Package perl-Devel-Dumpvar-0.04-1.fc11 =>
Provides: perl(Devel::Dumpvar) = 0.04
Requires: perl >= 0:5.005 perl(Scalar::Util) perl(UNIVERSAL) perl(strict)
perl(vars)
Suggestions:
1) Remove "BuildRequires: perl >= 0:5.005" from spec as its not needed
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list