[Bug 479798] Review Request: perl-Test-HTTP-Server-Simple-StashWarnings - Catch your forked server's warnings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479798


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-01-13 03:08:55 EDT ---
+ OK
- Need Work

Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1048832
+ rpmlint is silent for SRPM
+ rpmlint is NOT silent for RPM.
perl-Test-HTTP-Server-Simple-StashWarnings.noarch: W:
filename-too-long-for-joliet
perl-Test-HTTP-Server-Simple-StashWarnings-0.03-1.fc11.noarch.rpm
==>This filename is too long to fit on a joliet filesystem (limit is 64 unicode
chars).

+ source files match upstream url
0a63b8f45217f05611717292b7ec02e5 
Test-HTTP-Server-Simple-StashWarnings-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=8,  1 wallclock secs ( 0.01 usr  0.00 sys +  0.25 cusr  0.03
csys =  0.29 CPU)
+ Package perl-Test-HTTP-Server-Simple-StashWarnings-0.03-1.fc11 =>
  Provides:
  perl(Test::HTTP::Server::Simple::StashWarnings) = 0.03
  Requires:
  perl >= 0:5.008
  perl(NEXT)
  perl(Storable)
  perl(base)
  perl(strict)
  perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.