[Bug 470250] Review Request: docbook5-style-xsl - Norman Walsh's XSL stylesheets for DocBook 5
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jan 13 15:49:39 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470250
Michal Marciniszyn <mmarcini at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #6 from Michal Marciniszyn <mmarcini at redhat.com> 2009-01-13 10:49:37 EDT ---
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
42f5f41ff5822c57242d9413e7f98aef docbook-xsl-ns-1.74.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is NOT included in package.
redistributable without licence
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ package docbook5-style-xsl-1.74.0-1.fc10 ->
Provides:
docbook-xsl-ns = 1.74.0
docbook5-style-xsl = 1.74.0-1.fc10
Requires:
/bin/bash
/bin/sh
/bin/sh
/usr/bin/env
/usr/bin/perl
libxml2 >= 2.4.8
libxml2 >= 2.4.8
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
xml-common >= 0.6.3-8
+ Not a GUI app.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list