[Bug 478640] Review Request: dlfcn - mingw32-dlfcn

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478640





--- Comment #5 from Richard W.M. Jones <rjones at redhat.com>  2009-01-13 19:03:00 EDT ---
(In reply to comment #4)
> "Fix it with sed in the %prep section: %{__sed} -i 's/\r//' src/somefile --
> DONT use dos2unix, that can cause build fail on FC3. "
> 
> Well you should stick to the guidelines even if FC3 is long dead.

I'm missing the context here.  Was the above in reply to something?

> Pass %{?_smp_mflags} to make unless you have a reason not to do so.

I agree, this should be added.

> Will do a formal review later this week (limited time).

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.