[Bug 480037] Review Request: cups-pk-helper - PolicyKit support for system-config-printer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480037





--- Comment #3 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-01-14 13:26:21 EDT ---
Good
+ Package naming fits with naming guidelines
+ Basename of SPEC file matches with package name
+ License tag contains valid license
+ License GPLv2 is a valid OSS license
+ Local build works fine
+ Could download tar ball with spectool
+ Tar ball in source rpm matches with upstream
(md5sum: db1c91dcb3c9f7ef3270fe29c25178a4)
+ Consistently use of rpm macros
+ Buildroot will be clean on begin of %install and %clean
+ Local build works fine
+ Rpmlint doens't complaints debuginfo rpm
+ Local install works fine
+ Local uninstall wworks fine
+ Package contains no subpcakges
+ Build works fine on koji
+ Pakcage contains no files belong to others
+ Files Permissions looks right
+ Package contains valid %changelog stanza

Bad: 
- Rpmlint complaints source rpm:
cups-pk-helper.src: E: description-line-too-long cups-pk-helper is an
application, which helps system-config-printer to use PolicyKit infrastructure
- Rpmlint complaints binary rpm:
cups-pk-helper.x86_64: W: no-documentation
cups-pk-helper.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/org.opensuse.CupsPkHelper.Mechanism.conf
cups-pk-helper.x86_64: E: description-line-too-long cups-pk-helper is an
application, which helps system-config-printer to use PolicyKit infrastructure
- License tag should be GPLv2+, because the copyright notes in the source files
aloow use of later versions of the GPL.
- Verbatin copy of the license text is not included in the rpm, but available
in the original source tree.
- %doc stanza contains no files

question:
* Can I run a test without a printer. Is there a text plan for this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.