[Bug 477683] Review Request: fltk2 - C++ user interface toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477683


Michal Nowak <mnowak at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(bugs.michael at gmx.
                   |                            |net)




--- Comment #10 from Michal Nowak <mnowak at redhat.com>  2009-01-14 14:40:32 EDT ---
(In reply to comment #9)
> * The guidelines want you to choose either %buildroot or $RPM_BUILD_ROOT, not
> both.

OK. Will be fixed.

> * Use "install -p ..." especially when installing files yourself.

It's only in commented lines, will be removed completely in new revision.

> * Unowned directories alarm in -devel package! It can easily be seen that the
> following %files entries are missing:

Will fix.

> > %package       doc
> > Summary:       Doxygen documentation for FLTK2
> > Group:         Documentation
> > Requires:      %{name} = %{version}-%{release}
> 
> Why that?

Not sure what you mean. The whole sub-package seems to you useless, or you're
pointing to the 'Require:' field?

To the first point: it's 2.2 MB more data, which are not directly useful.
To the second one: sure it can be avoided, no problem here.

> > BuildRoot:     doxygen
> 
> Uh? A typo, most likely. Make that  BuildRequires: doxygen

Typo.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.