[Bug 478640] Review Request: mingw32-dlfcn - Implements a wrapper for dlfcn (dlopen dlclose dlsym dlerror)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478640


Adel Gadllah <adel.gadllah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #8 from Adel Gadllah <adel.gadllah at gmail.com>  2009-01-16 05:54:01 EDT ---
REVIEW:

[+] = OK
[-] = NOT OK
[1] = SEE COMMENTS
[?] = WTF?

===========================

[+] source files match upstream:
  sha1: 0b691107a23554d927987d4ddfca6e84dfd85313
[+] package meets naming and versioning guidelines.
[+] specfile is properly named, is cleanly written and uses macros
consistently.
[+] dist tag is present.
[+] build root is correct.
[+] license field matches the actual license.
[+] license is open source-compatible.
   LGPLv2+
[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] compiler flags are appropriate.
[+] %clean is present.
[+] package builds in koji.
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1058151
[+] package installs properly.
[1] rpmlint is silent.
[+] final provides and requires are sane
[+] no shared libraries are added to the regular linker search paths.
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[+] no scriptlets present.
[+] code, not content.
[+] documentation is small, so no -docs subpackage is necessary.
[+] %docs are not necessary for the proper functioning of the package.
[2] no headers.
[+] no pkgconfig files.
[+] no libtool .la droppings.

============================

COMMENTS

1: not silent.
mingw32-dlfcn.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libdl.dll.a
mingw32-dlfcn.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/dlfcn.h
mingw32-dlfcn.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libdl.dll.a
mingw32-dlfcn.noarch: W: non-standard-dir-in-usr i686-pc-mingw32

Those are fine thought (package used for cross compiling)

2: header is present, but its fine (cross compile package)

============================

Package looks good => APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.