[Bug 468462] Review Request: sbackup - Simple Backup Suite for desktop use

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468462





--- Comment #8 from Simon Wesp <cassmodiah at fedoraproject.org>  2009-01-16 18:41:12 EDT ---
(In reply to comment #7)
> - Please remove SystemSettings from the desktop files again, it's better for
> comptatibility. Sorry for the noise, apart from that the desktop files are ok
> now.

Okay! Done in -5


> - rpmlint warning regarding usermode can be ignored, but the changelog could be
> a little better, e. g.: "Require usermode-gtk instead of usermode for the
> password dialog." But this is really trivial.

Okay, you are right.


> - on the fly creation of files: Your decision, you are the one to maintain the
> package. ;)

Okay thank you

> - (How) Do we own the cron files?
mkdir -p
%{buildroot}%{_sysconfdir}/{cron.d,cron.daily,cron-hourly,cron.monthly,cron.weekly}/
touch
%{buildroot}%{_sysconfdir}/{cron.d,cron.daily,cron-hourly,cron.monthly,cron.weekly}/%{name}
%ghost %{_sysconfdir}/cron*/%{name}

this should do the trick...


> - Can you explain the makefile.patch a little? Why are you preventing
> installation of the desktop files and the locales?


i changed this part, completely! I hope you'll like it.
The patch for the makefile is now only for the settings of the directories and
the permission of the configfile. The makefile is damn ugly and almost
unusuable. I made a mix of patching makefile and installation via spec. this
was very ugly, too...


locales:
there are unofficial translations which are not listed in the makefile, but
shipped with sbackup.
why are they unofficial? 
These translation were made by the ubuntu-community (this project is an Ubuntu
project) so they are not made by the "upstream team" and are unofficial.
I added the others to use all available locales. I realized the installation of
the locales with a sed command. 

desktop files:
Now the original desktop files will be deleted and the new ones will installed.
Commenting out the desktopfiles in the makefile was a bad idea.



> - Provides: gvfs >= 1.0 looks bogus to me

yes, you are right. This is a bogus. I removed it in -5 

SPEC: http://cassmodiah.fedorapeople.org/sbackup-0.10.5/sbackup.spec
SRPM:
http://cassmodiah.fedorapeople.org/sbackup-0.10.5/sbackup-0.10.5-5.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.